Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix validation of pool when adding permission

tnisan at redhat.com tnisan at redhat.com
Wed Jul 13 13:54:23 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Fix validation of pool when adding permission
......................................................................


restapi: Fix validation of pool when adding permission

When adding a permission we check that there is an object provided, a
data center, a virtual machine, etc. But the validation for the pool
uses an incorrect name, "vmpool" instead of "vmPool". As a result the
validation always fail, and it is impossible to add a permission for a
pool. This patch fixes that issue.

Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c
Bug-Url: https://bugzilla.redhat.com/1354463
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit a6782813d66fecec7ff2f32e610375e4ac6527f9)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60645
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list