Change in ovirt-engine[master]: core: Fix test in VmDeviceDaoTest

tnisan at redhat.com tnisan at redhat.com
Sun Jul 17 12:31:39 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Fix test in VmDeviceDaoTest
......................................................................


core: Fix test in VmDeviceDaoTest

Fix testUpdateVmDeviceUsingScsiReservationProperty to actually load the
entity to compare the value of using usingScsiReservation rather than
redundantly compare the entity's usingScsiReservation to what we set it to

Change-Id: I0fa5916dfec1d100acde5212fc4b13d94d9ecb5c
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa5916dfec1d100acde5212fc4b13d94d9ecb5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list