Change in ovirt-engine[master]: core: rm StorageDomainFilterAbstractTest

amureini at redhat.com amureini at redhat.com
Wed Jul 20 13:45:58 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: rm StorageDomainFilterAbstractTest
......................................................................


core: rm StorageDomainFilterAbstractTest

With the removal of most of the test classes in the previous
patch, StorageDomainFilterAbstractTest remains an abstract base
class for only StorageDomainSpaceRequirementsFilterTest. In this
situation it doesn't make much sense keeping it, and it can easily be
squashed into StorageDomainSpaceRequirementsFilterTest.

Change-Id: Ibde06860d5d6930b5f684b47696f114599213d99
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainFilterAbstractTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainSpaceRequirementsFilterTest.java
2 files changed, 11 insertions(+), 25 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60686
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibde06860d5d6930b5f684b47696f114599213d99
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list