Change in ovirt-engine[master]: core: MemoryStorageHandler: Comparator.comparing

amureini at redhat.com amureini at redhat.com
Wed Jul 20 13:45:58 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: MemoryStorageHandler: Comparator.comparing
......................................................................


core: MemoryStorageHandler: Comparator.comparing

Use Java 8's Comparator.comapring instead of reinventing the wheel.

Change-Id: I421e5478088a8b008d3128daa8d25e0bca1b9afc
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainAvailableDiskSizeComparator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileFirstComparator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedFirstComparator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainAvailableDiskSizeComparatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileFirstComparatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedFirstComparatorTest.java
7 files changed, 21 insertions(+), 50 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I421e5478088a8b008d3128daa8d25e0bca1b9afc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list