Change in ovirt-engine[master]: userportal, webadmin: Fix of CCE in Guest Info subtab

tjelinek at redhat.com tjelinek at redhat.com
Mon Jul 25 12:02:19 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal, webadmin: Fix of CCE in Guest Info subtab
......................................................................


userportal, webadmin: Fix of CCE in Guest Info subtab

Showing 'Guest Inforamtion' subtab of pool row in userportal extended >
VMs threw ClassCastException. It was caused by getEntity() method in
VmGuestInfoModel returning instance of VmPool instead of expected VM.

* Guest Information subtab is hidden for pool rows.

* VmGuestInfoModel#updateProperties() doesnt't fail if getEntity returns
  object other than VM. It just returns.

Change-Id: I6a7f29167a1c364e160169908539e8881e1a7f2c
Bug-Url: https://bugzilla.redhat.com/1326076
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java
2 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a7f29167a1c364e160169908539e8881e1a7f2c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list