Change in ovirt-engine[master]: core: GetImageInfo to use GetVolumeInfo

laravot at redhat.com laravot at redhat.com
Tue Jul 26 09:33:33 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: GetImageInfo to use GetVolumeInfo
......................................................................


core: GetImageInfo to use GetVolumeInfo

GetImageInfoVDSCommand is an IRS command that executes getVolumeInfo
on the SPM.
Additionally, we have the GetVolumeInfoVDSCommand that executes getVolumeInfo on
the passed host in the parameters.

Currently GetVolumeInfoVDSCommand doesn't return the actual image info, but only if it
managed to get the volume information. As we need to use it to get the actual info
instead of duplicating the code or exporting it to a helper class we can change GetImageInfo
to use GetVolumeInfo and to pass it the SPM host id, maintaining the same behavior with less
code.

Change-Id: Iebfd4678e2422352567cba61ca363348867541c2
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java
8 files changed, 83 insertions(+), 175 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/60957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebfd4678e2422352567cba61ca363348867541c2
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list