Change in ovirt-engine[master]: webadmin: Fix of FE error while opening HTML5 console

tjelinek at redhat.com tjelinek at redhat.com
Wed Jul 27 12:35:20 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Fix of FE error while opening HTML5 console
......................................................................


webadmin: Fix of FE error while opening HTML5 console

Frontend error was thrown when HTML5 console was opened and the browser
blocked pop-up windows.

User is now notified using a dialog popup that opening console failed
and the reason might be the browser blocking opening new windows..

Change-Id: I8e28390f34b8a921ead66a715064f087d9252b30
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1327869
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 33 insertions(+), 15 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e28390f34b8a921ead66a715064f087d9252b30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list