Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Move readonly, boot and interface columns to disk ...

tnisan at redhat.com tnisan at redhat.com
Thu Jun 2 10:42:24 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Move readonly, boot and interface columns to disk attach popup
......................................................................


webadmin: Move readonly, boot and interface columns to disk attach popup

The updatable columns readonly, boot and interface columns that used to
be in DiskViewColumns are only used in the disk attach popup and also are
not really "view" columns as they are updatable, they were moved to
VmDiskAttachPopupWidget were they belong

Bug-Url: http://bugzilla.redhat.com/1341737
Change-Id: Ib878afde565c90da4318a4fcf180c19911dff6f2
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
2 files changed, 79 insertions(+), 72 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/58515
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib878afde565c90da4318a4fcf180c19911dff6f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list