Change in ovirt-engine[master]: core: Remove old shared status calculation

amureini at redhat.com amureini at redhat.com
Sun Jun 5 11:13:33 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove old shared status calculation
......................................................................


core: Remove old shared status calculation

Commit 904ab61 introduced an improved method of calculating a storage
domain's shared status, which is indeed currently in use in the
dwh_storage_domain_history_view.

That patch, however, left the old mechanism in place alongside the new
mechanism. This had no functional effect, as it's a left join on a
column that's never queried, but it does cause a redundant performance
penalty.

This patch fixes the problem by removing this redundant join.

Related-To: https://bugzilla.redhat.com/1306325
Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/58506
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list