Change in ovirt-engine[master]: core: AddLocalStorageDomainCommand#validate early return

amureini at redhat.com amureini at redhat.com
Mon Jun 13 10:01:05 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddLocalStorageDomainCommand#validate early return
......................................................................


core: AddLocalStorageDomainCommand#validate early return

Use the early return (fail-fat) idiom to clean up the code and make it
easier to read.

Change-Id: I6be202168a5131d2f0a16b104d2a826c49f901de
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java
1 file changed, 31 insertions(+), 32 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59028
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6be202168a5131d2f0a16b104d2a826c49f901de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list