Change in ovirt-engine[master]: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executed...

amureini at redhat.com amureini at redhat.com
Wed Jun 15 07:09:30 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedRemovedIds
......................................................................


core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedRemovedIds

The executedRemovedIds member in
ProcessOvfUpdateForStoragePoolCommandTest is just updated but never
queried. Thus, it is redundant, and can (and should!) be removed.

Where removing it reduced a doAnswer block to a simple return statement,
the doAnswer was simplified to doReturn to avoid code bloating.

Change-Id: I4c44f17f9bc8a411e74e42b1be5a439fb89dcced
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 1 insertion(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59134
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c44f17f9bc8a411e74e42b1be5a439fb89dcced
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list