Change in ovirt-engine[master]: webadmin: speed up text truncation detection

gshereme at redhat.com gshereme at redhat.com
Wed Jun 15 14:48:58 UTC 2016


Greg Sheremeta has submitted this change and it was merged.

Change subject: webadmin: speed up text truncation detection
......................................................................


webadmin: speed up text truncation detection

Previously, the algorithm for detecting horizontal
text truncation was bad and really slow. Improved it.

The algorithm for detecting vertical truncation was
good, but really slow. There is no performant way to
detect this. But, I don't think we really need it.
So, removing it.

Change-Id: I81476b018fa96ff182339053c1e8b5eba9207dc1
Bug-Url: https://bugzilla.redhat.com/1326513
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
5 files changed, 14 insertions(+), 28 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56719
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81476b018fa96ff182339053c1e8b5eba9207dc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list