Change in ovirt-engine[ovirt-engine-3.6]: core: Connect all hosts on adding storage pool.

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Jun 16 09:05:35 UTC 2016


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: Connect all hosts on adding storage pool.
......................................................................


core: Connect all hosts on adding storage pool.

Once we create a storage pool with multiple hosts, we connect the first
host to all the storage domains and create a storage pool.
After the create succeeded, the flow continues, and tries to fetch
all the unregistered disks before all the hosts in the Data Center
are connected to all the storage domains.

As part of the query of getting the unregistered disks, the engine uses
the getImagesList query.
This vds command uses IrsProxyData which executes
ConnectStoragePoolVDSCommand, and the host that execute this method uses
a random host which might not be connected.

To avoid this problem, once we have a host which successfully created a
storage pool we keep connect all the rest of the storage domains since
they are already being connected when getting activated.

Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk at gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
1 file changed, 17 insertions(+), 10 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/59270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list