Change in ovirt-engine[master]: core: final VmDevicesMonitoring#devicesStatusesLock

ahadas at redhat.com ahadas at redhat.com
Thu Jun 16 12:46:16 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: final VmDevicesMonitoring#devicesStatusesLock
......................................................................


core: final VmDevicesMonitoring#devicesStatusesLock

Converted the effectively final devicesStatusesLock to actually be
final, as it's used as a lock, and changing the reference by mistake may
introduce hard to find bugs.

Note that this patch solves a warning reported by IntelliJ IDEA.

Change-Id: Ie7ca0121b5423a9bf184577ade4cc6d0e9fb1299
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Allon Mureinik: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/58822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7ca0121b5423a9bf184577ade4cc6d0e9fb1299
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list