Change in ovirt-engine[master]: restapi: Fix adding of quota storage limits

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jun 22 07:52:39 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Fix adding of quota storage limits
......................................................................


restapi: Fix adding of quota storage limits

The quota limit resources use inheritance and generics in order to avoid
implementing the "add" operation twice, once for cluster limits and
another time for storage limits. Unfortunately the JAX-RS implementation
that we use doesn't recognize these generic "add" operations, resulting
in a 405 error message when they are used. To avoid that error this
patch refactors the relevant resources so that they don't use
inheritance and generics. The result is more verbose, but simpler, and
works.

Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4
Bug-Url: https://bugzilla.redhat.com/1348559
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java
3 files changed, 74 insertions(+), 72 deletions(-)

Approvals:
  Juan Hernandez: Verified; Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list