Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix adding of quota storage limits

tnisan at redhat.com tnisan at redhat.com
Wed Jun 22 10:15:36 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Fix adding of quota storage limits
......................................................................


restapi: Fix adding of quota storage limits

The quota limit resources use inheritance and generics in order to avoid
implementing the "add" operation twice, once for cluster limits and
another time for storage limits. Unfortunately the JAX-RS implementation
that we use doesn't recognize these generic "add" operations, resulting
in a 405 error message when they are used. To avoid that error this
patch refactors the relevant resources so that they don't use
inheritance and generics. The result is more verbose, but simpler, and
works.

Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4
Bug-Url: https://bugzilla.redhat.com/1348559
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 1500465386f3e6d391d8a6a33d232be423cf46c0)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java
3 files changed, 74 insertions(+), 72 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list