Change in ovirt-engine[master]: Adding JsonProperty to fix parsing of foreman entities

oourfali at redhat.com oourfali at redhat.com
Wed Jun 22 11:25:32 UTC 2016


Oved Ourfali has submitted this change and it was merged.

Change subject: Adding JsonProperty to fix parsing of foreman entities
......................................................................


Adding JsonProperty to fix parsing of foreman entities

For every two or more words field we need explicitly to describe its json name.
In engine the style convention is to use capital latter between words. The
json schema separates words with underscore.
This code used to work before with older jackson package, currently its
mandatory to work properly.

Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Bug-Url: https://bugzilla.redhat.com/1348916
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java
3 files changed, 22 insertions(+), 3 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59413
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list