Change in ovirt-engine[ovirt-engine-4.0]: Adding JsonProperty to fix parsing of foreman entities

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Jun 24 11:54:31 UTC 2016


Piotr Kliczewski has submitted this change and it was merged.

Change subject: Adding JsonProperty to fix parsing of foreman entities
......................................................................


Adding JsonProperty to fix parsing of foreman entities

For every two or more words field we need explicitly to describe its json name.
In engine the style convention is to use capital latter between words. The
json schema separates words with underscore.
This code used to work before with older jackson package, currently its
mandatory to work properly.

Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Bug-Url: https://bugzilla.redhat.com/1348916
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
(cherry picked from commit 52c675cd4c7013a900c6060074160e92dc246a70)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java
3 files changed, 22 insertions(+), 3 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list