Change in ovirt-engine[master]: webadmin: Verify that a disk exists when setting its interface.

tnisan at redhat.com tnisan at redhat.com
Sun Jun 26 12:24:12 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Verify that a disk exists when setting its interface.
......................................................................


webadmin: Verify that a disk exists when setting its interface.

In cases where adding a new disk to a VM, the model should add the
default interface. Currently the code wants to infer the interface by
the vm's disk. but since there is no disk, a NPE is thrown.

Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7
Bug-Url: https://bugzilla.redhat.com/1344367
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/59780
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list