Change in ovirt-engine[ovirt-engine-4.0]: core: Allow user to create a vm from blank template on local...

tnisan at redhat.com tnisan at redhat.com
Sun Jun 26 15:04:24 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Allow user to create a vm from blank template on local storage
......................................................................


core: Allow user to create a vm from blank template on local storage

When user creates a new vm from blank template on local storage the vm
is pinned to the one host that exists on the storage.
Since the blank template is not pinned to a specific host the
authorization for that action fails (the dedicated host of the vm is
compared to the dedicated host of the template and since only admin is
allowed to change hosts and the template is not pinned an exception is
thrown).
The fix is to remove the comparison of hosts in case the vm is created
from a default template.

Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997
Bug-Url: https://bugzilla.redhat.com/1284472
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
(cherry picked from commit 4522754)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/59786
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list