Change in ovirt-engine[master]: restapi: Map correctly disk interface types

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jun 27 09:57:07 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Map correctly disk interface types
......................................................................


restapi: Map correctly disk interface types

Currently the mapping of disk interfaces is implemented using string
translation, thus assuming that the names of the enums are exactly the
same in the backend and in the API. But that isn't true. This patch
changes that mapping so that it uses type safe enums.

Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Bug-Url: https://bugzilla.redhat.com/1349594
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
3 files changed, 41 insertions(+), 40 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list