Change in ovirt-engine[ovirt-engine-4.0]: restapi: Map correctly disk interface types

tnisan at redhat.com tnisan at redhat.com
Mon Jun 27 10:34:16 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Map correctly disk interface types
......................................................................


restapi: Map correctly disk interface types

Currently the mapping of disk interfaces is implemented using string
translation, thus assuming that the names of the enums are exactly the
same in the backend and in the API. But that isn't true. This patch
changes that mapping so that it uses type safe enums.

Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Bug-Url: https://bugzilla.redhat.com/1349594
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 84ff17784ea1784df62bd6daf42b53c1ee3e422e)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
3 files changed, 41 insertions(+), 40 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59808
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list