Change in ovirt-engine[master]: core: prevent duplicate watchdog device on new vm

ahadas at redhat.com ahadas at redhat.com
Tue Mar 1 14:53:05 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: prevent duplicate watchdog device on new vm
......................................................................


core: prevent duplicate watchdog device on new vm

When a template is set with watchdog device and the user creates a
VM from that template, the VM ends up with 2 watchdog devices:
1. The one that was copied from the template
2. Additional device that is added by AddVmCommand#addVmWatchdog

The solution is not to add another watchdog device if one is already
defined in the template.

Change-Id: I1280cb9fe3f9e9047c796bf54cb05dceda4ff43f
Bug-Url: https://bugzilla.redhat.com/1304676
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
2 files changed, 17 insertions(+), 7 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified
  Liron Aravot: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1280cb9fe3f9e9047c796bf54cb05dceda4ff43f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list