Change in ovirt-engine[master]: webadmin: Do not fetch disk info together with VM templates

ahadas at redhat.com ahadas at redhat.com
Thu Mar 3 08:07:58 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: webadmin: Do not fetch disk info together with VM templates
......................................................................


webadmin: Do not fetch disk info together with VM templates

In GetVmTemplatesByStoragePoolId and GetVmTemplatesFromStorageDomain
queries, the disk info fetched by them is not used in most situations.
However, fetching the excessive data takes time and slows down the UI.
This patch gets rid of disk info where it is not needed.

In particular, in 'New VM' and similar dialogs the disk info for the
currently selected template is queried separately, while the disk info
fetched previously for every template in the list is not used at all.

Change-Id: I6fa007c1cc7b49efb3d9d4e1c01a852aa8a3cf62
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308478
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesFromStorageDomainParameters.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageTemplateListModel.java
7 files changed, 40 insertions(+), 12 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fa007c1cc7b49efb3d9d4e1c01a852aa8a3cf62
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list