Change in ovirt-engine[master]: restapi: Check result of loading YAML metadata

juan.hernandez at redhat.com juan.hernandez at redhat.com
Sat Mar 5 18:01:43 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Check result of loading YAML metadata
......................................................................


restapi: Check result of loading YAML metadata

Currently the method that loads the YAML metadata doesn't check if the
result is null, and this is reported as a defect by some code auditing
tools. To avoid that defect this patch changes the code so that it
checks for null and throws an exception.

Change-Id: Ie2d64f1233d16f5acfbbd3890944deba72bff274
Coverity-Id: 1229037
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
1 file changed, 13 insertions(+), 4 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2d64f1233d16f5acfbbd3890944deba72bff274
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list