Change in ovirt-engine[master]: restapi: Avoid potential NPEs in link helper

juan.hernandez at redhat.com juan.hernandez at redhat.com
Sat Mar 5 18:02:28 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Avoid potential NPEs in link helper
......................................................................


restapi: Avoid potential NPEs in link helper

There are several places in the link helper where methods are called
using references that could theoretically be null. This adds the null
checks to avoid these potential NPEs.

Change-Id: Ida284223e50bdc94ee3a1672433a0ed31cbbdefa
Coverity-Id: 1352154, 1352155, 1352156
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
2 files changed, 28 insertions(+), 11 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida284223e50bdc94ee3a1672433a0ed31cbbdefa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list