Change in ovirt-engine[master]: core: SetupNetworksVDSCommand null check

amureini at redhat.com amureini at redhat.com
Wed Mar 16 11:03:39 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: SetupNetworksVDSCommand null check
......................................................................


core: SetupNetworksVDSCommand null check

By examining VdsDynamic#getSupportedClusterVersionsSet and
VdsDynamic#parseSupportedVersions, it is clear that
getSupportedClusterVersionsSet() will never return null. Thus, checking
it is redundant (and confusing).

This patch removes this redundant null check.

Change-Id: Id52346bae23f3fbdc5e39022654c4bdafdd96a89
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id52346bae23f3fbdc5e39022654c4bdafdd96a89
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list