Change in ovirt-engine[master]: core: Remove wrong code in AddVmFromScratchCommand

tnisan at redhat.com tnisan at redhat.com
Thu Mar 17 12:14:40 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove wrong code in AddVmFromScratchCommand
......................................................................


core: Remove wrong code in AddVmFromScratchCommand

AddVmFromScratchCommand is called in all flows when a VM is created with a
blank template, in the case the VM cannot have disks to be created thus the
logic within addVmImages is incorreect and removed

Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
1 file changed, 1 insertion(+), 49 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54811
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list