Change in ovirt-engine[master]: core: FeatureSupported getOrDefault usage

amureini at redhat.com amureini at redhat.com
Mon Mar 21 05:59:45 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: FeatureSupported getOrDefault usage
......................................................................


core: FeatureSupported getOrDefault usage

FeatureSupported is in the common module, and as such, it should only
use JDK 7 methods (since GWT does not yet support JDK 8 methods, as
verified by animal-sniffer).

This patch removes the usage of getOrDefault and implements an
equivalent logic (under the assumption that the config map may not
contain null values) in-place by checking if the value returned from
the get method was null or not.

Change-Id: Ibb7775796005d8a65f1741e01458589e95f33ac1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb7775796005d8a65f1741e01458589e95f33ac1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list