Change in ovirt-engine[master]: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds

ahadas at redhat.com ahadas at redhat.com
Mon Mar 21 10:48:18 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds
......................................................................


engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds

Refactoring of VmHandler.

The COMMANDS_ALLOWED_ON_ moved from VmHandler to
new VmActionByVmOriginTypeValidator, so they can be reused in UI.

Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651
Signed-off-by: Marek Libra <mlibra at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
3 files changed, 42 insertions(+), 23 deletions(-)

Approvals:
  Marek Libra: Verified
  Arik Hadas: Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54870
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list