Change in ovirt-hosted-engine-ha[master]: storage: improved workaround for getImagesList on NFS

msivak at redhat.com msivak at redhat.com
Mon Mar 21 14:30:17 UTC 2016


Martin Sivák has submitted this change and it was merged.

Change subject: storage: improved workaround for getImagesList on NFS
......................................................................


storage: improved workaround for getImagesList on NFS

We know from the past that getImagesList wasn't properly working
on 3.6 on NFS StorageDomain when the host was not connected to a
storagePool (as it happened in hosted-engine scenario).

There was a workaround for that triggered by an explicit error
in getImagesList return value ({'status': {'message': 'list index out
of range', 'code': 100}}).

Now it seems that getImagesList has started to report success (code=0)
for this case, although the image list is still empty.

This patch improves the workaround to catch that.

Change-Id: I26ed9e823f60415b500b87f11e91128228b45dec
Bug-Url: https://bugzilla.redhat.com/1319721
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M ovirt_hosted_engine_ha/lib/image.py
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Sivák: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26ed9e823f60415b500b87f11e91128228b45dec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list