Change in ovirt-engine[master]: engine: Remove hotplugged memory & CPUs from changed fields ...

ahadas at redhat.com ahadas at redhat.com
Sun Mar 27 12:13:39 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: engine: Remove hotplugged memory & CPUs from changed fields list
......................................................................


engine: Remove hotplugged memory & CPUs from changed fields list

If number of CPUs or memory size is changed when VM is running, special
info is displayed in the confirmation dialog about hotplugging CPUs or
memory. In the same time, numOfSockets and memSizeMb fields are present
in the list of fields to be changed on the next VM run. Noting these
fields there is redundant, so it was eliminated.

Note that memSizeMb is removed only in the case of memory plugging, but
not in the case of unplugging. Confirmation dialog currently assumes
that memory hot unplugging is not supported and decreased memory size is
applied only on the next VM run.

Change-Id: I38a52f7bfe4f4b6ab35b07e7526746f748c5b92d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314426
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38a52f7bfe4f4b6ab35b07e7526746f748c5b92d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list