Change in ovirt-engine[master]: core: SystemUtils.LINE_SEPARATOR->System.lineSeparator()

amureini at redhat.com amureini at redhat.com
Mon Mar 28 23:16:18 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: SystemUtils.LINE_SEPARATOR->System.lineSeparator()
......................................................................


core: SystemUtils.LINE_SEPARATOR->System.lineSeparator()

Since JDK 8 provides a standard way to get the system's line separator
there's no need to rely on third party libraries like Apache Commons
Lang.

This patch removes such usages and uses the standard JDK implementation
in order to reduce external dependencies and standardize the code.

Change-Id: I78e7ad7559480deb18a3d0073a522a54da5d2a62
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
6 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78e7ad7559480deb18a3d0073a522a54da5d2a62
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list