Change in ovirt-engine[master]: core: Remove VdcActionType#MoveOrCopyVmTemplate

amureini at redhat.com amureini at redhat.com
Wed Mar 30 17:24:04 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove VdcActionType#MoveOrCopyVmTemplate
......................................................................


core: Remove VdcActionType#MoveOrCopyVmTemplate

oVirt 3.0 had a command to copy a VM Template from one storage domain
to another.
oVirt 3.1 introduced the notion of a VM Template having multiple disks
on multiple storage domains, with the ability to copy them independently,
rendering this command meaningless, and it is indeed not used in the
codebase, and hasn't been for a while.

This patch removes the constant representing it and all the tooling
around it (ExecutionMessages constant, LocalizedEnums translations,
etc.). Subsequent patches will remove the actual code for the
MoveOrCopyTemplateCommand, once the classes that extend it will be
cleaned up.

Change-Id: I64ae7eba3834e5b3347d740c81763d6308ccdc86
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/async_tasks_map.py
6 files changed, 2 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55090
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64ae7eba3834e5b3347d740c81763d6308ccdc86
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list