Change in ovirt-engine[master]: core: Inline MoveOrCopyTemplateCommand#getImagesActionType

amureini at redhat.com amureini at redhat.com
Wed Mar 30 17:27:53 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Inline MoveOrCopyTemplateCommand#getImagesActionType
......................................................................


core: Inline MoveOrCopyTemplateCommand#getImagesActionType

As MoveOrCopyTemplateCommand#getImagesActionType now returns a constant
VdcActionType.CopyImageGroup, there's no reason to have it as a method.

This patch inlines this method and replaces it with its implementation
in order to clean up the code and make it easier to read.

Change-Id: I7fd646d87a46ba9c0b141c8df36b161e1b9ee132
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
3 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fd646d87a46ba9c0b141c8df36b161e1b9ee132
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list