Change in ovirt-engine[master]: core: Inline MoveOrCopyTemplateCommand#validate()

amureini at redhat.com amureini at redhat.com
Wed Mar 30 17:27:55 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Inline MoveOrCopyTemplateCommand#validate()
......................................................................


core: Inline MoveOrCopyTemplateCommand#validate()

The only place that used MoveOrCopyTemplateCommand#validate() is
ExportVmTemplateCommand#validate(), which calls super.validate(). This
patch inlines the relevant checks there and removes the redundant method
from MoveOrCopyTemplateCommand.

This change also allows us to remove the duplicate check of
"getVmTemplate() == null".

Change-Id: I7af044fd8fd78fb9aa1a81ba821ad12c56b5771f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
2 files changed, 40 insertions(+), 52 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7af044fd8fd78fb9aa1a81ba821ad12c56b5771f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list