Change in ovirt-engine[master]: core: Fail fast ExportVmTemplateCommand#validate()

amureini at redhat.com amureini at redhat.com
Wed Mar 30 17:27:55 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fail fast ExportVmTemplateCommand#validate()
......................................................................


core: Fail fast ExportVmTemplateCommand#validate()

Cleaned up the ExportVmTemaplateCommand#validate() method to use the
early-return (fail-fast) idiom in order to clean up the code and make it
more readable, instead of dragging the retVal variable throughout the
method.

Change-Id: I73ad6ae1b52461bc4afbfcd7a6263da9148e966a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java
1 file changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55096
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I73ad6ae1b52461bc4afbfcd7a6263da9148e966a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list