Change in ovirt-engine[master]: core: Revert "core: removing ChildCommandsCallbackBase"

laravot at redhat.com laravot at redhat.com
Thu Mar 31 06:23:12 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: Revert "core: removing ChildCommandsCallbackBase"
......................................................................


core: Revert "core: removing ChildCommandsCallbackBase"

This reverts commit 53306594d2ec4b2a64a816df198bacd195fcb94b.
The reverted commit added a bug in SerialChildCommandsExecutionCallback, the command
end status is set even if more commands are executed in performNextOperation() which
is wrong.

This patch reverts the change, if we'll want it can be pushed again with applied fix.

Change-Id: I996a7cd8c9cbad2fc8608779db73bb6ca30271b3
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java
3 files changed, 164 insertions(+), 142 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/55475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I996a7cd8c9cbad2fc8608779db73bb6ca30271b3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list