Change in ovirt-engine[master]: Frontend: add VM name to console title of noVNC, SPICE HTML5

tjelinek at redhat.com tjelinek at redhat.com
Mon May 2 09:35:10 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: Frontend: add VM name to console title of noVNC,SPICE HTML5
......................................................................


Frontend: add VM name to console title of noVNC,SPICE HTML5

In case of opening a console to VM using either noVNC client or
SPICE HTML5 clients (both consoles running inside the browser) -
the VM name wasn't displayed in title.

before this fix:
for noVNC - the console title was "noVNC".
for SPICE HTML5 - the console title was "Spice Javascript Client".

This patch added the VM name to the title for both protocols.

Bug-Url: https://bugzilla.redhat.com/1313295
Change-Id: If3897b7932e2fa5bd0567c091c47751c32e07675
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
M backend/manager/modules/services/src/main/webapp/spicehtml5-main.html
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
7 files changed, 25 insertions(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/56878
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3897b7932e2fa5bd0567c091c47751c32e07675
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list