Change in ovirt-engine[master]: core, db: Better convention for Image Upload URI configuration

mlipchuk at redhat.com mlipchuk at redhat.com
Wed May 4 18:53:03 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: core, db: Better convention for Image Upload URI configuration
......................................................................


core, db: Better convention for Image Upload URI configuration

The existing configuration for URIs related to Image Upload was not
clear, and also split some settings between the engine and proxy.

This change:
1. Moves the image daemon port setting to the engine where it belongs.
2. Makes SSL enablement more explicit.
3. Updates the proxy port setting to match the default listening port
   of the proxy.
4. Uses a more standardized address:port format for the proxy address,
   which we can later extend to included multiple addresses if desired.

Change-Id: Id489f2526513a70991432af7235c7d42b5f16107
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 25 insertions(+), 9 deletions(-)

Approvals:
  Greg Padgett: Verified
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id489f2526513a70991432af7235c7d42b5f16107
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list