Change in ovirt-engine[master]: core: Remove disk ID from UpdateVmDiskParameters

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove disk ID from UpdateVmDiskParameters
......................................................................


core: Remove disk ID from UpdateVmDiskParameters

Since the parameters already contain the disk info the disk ID field is
completely redundant not to mention confusing since you can theoretically
update a disk with different ID in the disk info and the disk ID selected
After making sure that all places that are creating those parameters are
taking the disk ID from the disk info this field could be removed safely

Change-Id: I84edff9f10bf56e3cb60e78e401884c56ad6e0a1
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/ExtendCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmDiskParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
7 files changed, 18 insertions(+), 29 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Liron Aravot: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57032
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84edff9f10bf56e3cb60e78e401884c56ad6e0a1
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>