Change in ovirt-engine[master]: core: Remove HotPlugDiskToVmCommand

tnisan at redhat.com tnisan at redhat.com
Tue May 10 13:05:27 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove HotPlugDiskToVmCommand
......................................................................


core: Remove HotPlugDiskToVmCommand

After moving all usages of HotPlugDiskToVmCommand to DiskVmElement the
class no longer adds functionality over its superclass thus can safely be
removed and replaced by its superclass VmDiskOperationParameterBase

Change-Id: I3cee254345deda73db0aa555b7305d9c6b15e674
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommandTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotPlugDiskToVmParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
9 files changed, 22 insertions(+), 39 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Daniel Erez: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cee254345deda73db0aa555b7305d9c6b15e674
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list