Change in ovirt-engine[master]: core: make MonitoringStrategyFactory singleton

ahadas at redhat.com ahadas at redhat.com
Tue May 10 13:35:56 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: make MonitoringStrategyFactory singleton
......................................................................


core: make MonitoringStrategyFactory singleton

MonitoringStrategyFactory used to have static fields/utility methods.
This patch changes it to be Singleton so it would be possible to
inject DAOs for it.

Change-Id: I010c45436aa9dc8b0bf82d6a56a59f99e86c94cd
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/MonitoringStrategyFactory.java
4 files changed, 52 insertions(+), 22 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/57229
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I010c45436aa9dc8b0bf82d6a56a59f99e86c94cd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list