Change in ovirt-engine[master]: core: Change permissionCheckSubject for inherited command.

mlipchuk at redhat.com mlipchuk at redhat.com
Wed May 18 11:26:21 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Change permissionCheckSubject for inherited command.
......................................................................


core: Change permissionCheckSubject for inherited command.

Based on the commit Ida67a4409509652d5eeb1a953c3537051e4e61bb,
StorageDomainCommandBase implements the getPermissionCheckSubjects with
a new ArrayList and avoid using Singleton list.
Based on that AttachStorageDomainToPoolCommand can avoid using two lists
and use only the one which was created at StorageDomainCommandBase.

Change-Id: Ia5c9e1b068272d2c876a43437368cccfd8437816
Signed-off-by: Maor Lipchuk <maorlipchuk at gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5c9e1b068272d2c876a43437368cccfd8437816
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list