Change in ovirt-hosted-engine-setup[master]: storage: pass mount options via answerfile

stirabos at redhat.com stirabos at redhat.com
Mon May 23 13:20:22 UTC 2016


Simone Tiraboschi has submitted this change and it was merged.

Change subject: storage: pass mount options via answerfile
......................................................................


storage: pass mount options via answerfile

Some scenario could require custom mount options calling
connectStorageServer on the hosted-engine storage domain.
Adding an optional parameter to store it in the conf file
if a value has been supplied via answerfile.
Doing it interactively will require to propose a
reasonable default and validate the user input so it
will addressed in a future patch.

Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289
Bug-Url: https://bugzilla.redhat.com/1298693
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-setup/core/conf.py
M src/plugins/gr-he-setup/storage/blockd.py
M src/plugins/gr-he-setup/storage/storage.py
M templates/hosted-engine.conf.in
5 files changed, 36 insertions(+), 12 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Simone Tiraboschi: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/57765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fb6e6ff4cfd9b794c54b6a4c8e9de3ee2de9289
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list