Change in ovirt-engine[master]: webadmin: v2v-source vms list is cleaned in failure

tjelinek at redhat.com tjelinek at redhat.com
Wed May 25 06:42:28 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: v2v-source vms list is cleaned in failure
......................................................................


webadmin: v2v-source vms list is cleaned in failure

While opening the Webadmin Import VM dialog and importing from
VMware source or any other external source (v2v), the "virtual
machines on source" list was not cleaned in case of entering
invalid parameters.

After this fix: if you enter valid parameters and click the
"load" button -> the "virtual machines on source" list is displayed.
If you then enter incorrect parameters and click
the "load" button again (either field validation failure or
connection failure), the "virtual machines on
source" list is now cleaned while an error is displayed.

The bug was opened for VMware but this fix is done for
all external sources.

Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372
Bug-Url: https://bugzilla.redhat.com/1298293
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/57841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list