Change in ovirt-engine[master]: core: fix monitoring of guest agent nics

ahadas at redhat.com ahadas at redhat.com
Tue May 31 09:08:31 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: fix monitoring of guest agent nics
......................................................................


core: fix monitoring of guest agent nics

We used to to compare the hash that is being calculated by the engine (of
network interfaces reported by the guest agent) with the hash in the
dynamic VM data reported by VDSM. The problem is that VDSM doesn't report
this hash, therefore it is always zero and therefore we update the dynamic
data of a VM that is installed with guest agent on each monitoring cycle.

This patch fixes this by changing the mentioned check so the computed
hash will be compared to the one that was calculated previously.

Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/58303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list