Change in ovirt-engine[master]: webadmin: show "Disk Allocation" only when there are disks

mbetak at redhat.com mbetak at redhat.com
Fri May 20 19:23:03 UTC 2016


Martin Betak has submitted this change and it was merged.

Change subject: webadmin: show "Disk Allocation" only when there are disks
......................................................................


webadmin: show "Disk Allocation" only when there are disks

It looked confusing to have label "Disk Allocation:" and nothing under it.

Fixed by showing the label only if there is at least one disk.

Change-Id: I0a5eb00496e63ab1ec6c81a26130c166ef7cf60c
Bug-Url: https://bugzilla.redhat.com/1337619
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.ui.xml
3 files changed, 15 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5eb00496e63ab1ec6c81a26130c166ef7cf60c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list