Change in ovirt-engine[ovirt-engine-4.0]: core: removed static calls to DbFacade in UploadImage commands

Code Review gerrit at ovirt.org
Thu Nov 3 09:48:53 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: removed static calls to DbFacade in UploadImage commands
......................................................................


core: removed static calls to DbFacade in UploadImage commands

Introduced ImageTransferUpdater bean:
* Contains the logic of UploadImageCommand -> updateEntity.
* Injected in UploadImageCommand and UploadImageStatusCommand.
* Used in order to avoid static calls to DbFacade.

Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2
Signed-off-by: Daniel Erez <derez at redhat.com>
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java
3 files changed, 123 insertions(+), 81 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/65957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list