Change in ovirt-engine[master]: core: Add tests to VmValidator::validateCpuSockets

Code Review gerrit at ovirt.org
Thu Nov 3 16:40:48 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Add tests to VmValidator::validateCpuSockets
......................................................................


core: Add tests to VmValidator::validateCpuSockets

Now that validateCpuSockets is in the right place it can be unit tested
properly

Change-Id: Ie3b25a1324c1a1a2868b9d3676cc3ee4eb360720
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java
1 file changed, 78 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65985
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3b25a1324c1a1a2868b9d3676cc3ee4eb360720
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list